On 06/21/2016 10:53 AM, Carl Meyer wrote: > If we're OK in the long term with making middleware-turned-decorator > authors responsible for correctly handling TemplateResponse themselves, > we should just go there right away via > https://github.com/django/django/pull/6765 -- we can take care of > backwards-compatibility quite nicely there in the transition mixin. In > fact I'd say the overall backward-compatibility of this approach (#6765) > is better than that of #6805 (the extra-middleware-annotation approach), > due to converting all our builtin decorators-from-middleware to the new > style in the latter. > > The downside of #6765 is that the boilerplate for correctly handling > TemplateResponse is pretty ugly [1], and any middleware that accesses > response.content would pretty much need to do that, in case it might > sometime be used in decorator_from_middleware. > > To be honest though, I'm still not sure that isn't our best option. Most > middleware I've written don't access response.content, they set headers, > so they'd be unaffected. Some of Django's built-in ones do touch > content, but we can deal with the ugly TemplateResponse boilerplate in > our own middleware.
We could also leave MiddlewareMixin in place indefinitely, and people who don't want to do advanced things in __call__ (like using context managers) can keep inheriting from the mixin and writing process_request and process_response methods until eternity. Then the mixin takes care of TemplateResponse deferral and they don't need to worry about it. Carl -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/57697232.7010501%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
