I noticed that the GIS widgets didn't use the new API so I added a commit for that. I tested the widgets in the geodjango tutorial and they looked okay. I'm not sure how well those widgets are tested in Django's test suite -- if any GIS users want to review the changes and/or test the branch with their own project, that would be welcome.
I also did a little polish on the documentation. If there's no further feedback, I think we could merge this sometime next week. If you would like to review it and don't have time until a certain day, just let me know and I'll delay the merge as needed. Thanks! https://github.com/django/django/pull/6498 On Tuesday, December 20, 2016 at 6:01:58 PM UTC-5, Tim Graham wrote: > > TemplatesSetting seems okay to me (open to other consensus though). > > PR is updated: https://github.com/django/django/pull/6498 > > On Tuesday, December 20, 2016 at 5:19:32 PM UTC-5, Carl Meyer wrote: >> >> >> On 12/20/2016 02:04 PM, Tim Graham wrote: >> > I think it would be nice to be able to look at the name of the >> "project" >> > renderer and understand that it's connected to settings.TEMPLATES. I'm >> > not sure if the term "project" does that well. Maybe >> > "TemplatesSettingEngines"? >> >> Yeah... I guess I thought ProjectTemplates got reasonably close to that, >> since settings.TEMPLATES is the template configuration for your project. >> I guess "TemplatesSettingEngines" could be OK, it just fails to roll off >> the tongue. Not sure why we'd tack on "Engines" when we don't to any of >> the other names (even though they all use a template engine or engines); >> maybe just "django.forms.renderers.TemplatesSetting"? >> >> I still slightly prefer "ProjectTemplates", but you're painting the >> bikeshed, feel free to choose the color :-) >> >> Carl >> >> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e1dbc1f9-e9b4-4a25-b1e4-c33747d91530%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
