Not sure that's what's being suggested here James?

But I'm -1 on this because it's adding more coupling between models and
forms.

Also Jamesie, can't you just subclass in your ModelAdmin to
replace get_form / View classes to replace get_form_class and achieve the
same thing? As far as I understand the only thing your suggestion changes
is that the forms used in views and admin can be changed at once, which is
not necessarily desirable as both are intended for different users.

On Mon, 20 Aug 2018 at 15:38, James Bennett <ubernost...@gmail.com> wrote:

> I'd be -1 on anything that encourages people to use ModelForm with all
> fields included by default; that's asking for mass-assignment security
> holes.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAL13Cg--AGfXz4uLtAbC0miGCrQE9M1o6_cbC114UULBVhOPJg%40mail.gmail.com
> <https://groups.google.com/d/msgid/django-developers/CAL13Cg--AGfXz4uLtAbC0miGCrQE9M1o6_cbC114UULBVhOPJg%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM0wXj1%2B-jk61f-MHarZjMdXpYmPptxf4cC0SXZD1WvOqA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to