Hey Simon I have made some changes to the proposal. I kindly request you to take a look at it and give any feedback you can :)
https://gist.github.com/aryan9600/b1c2eaf445006c17e02e7677cf1098d5 Kind Regards Sanskar On Wed, 25 Mar 2020 at 23:57, charettes <charett...@gmail.com> wrote: > Are you thinking about the Operation.state_forwards logic? I guess it > would make it easier to test state alterations in isolation but I don't > think it's necessary for this already large project. > > Cheers, > Simon > > Le mercredi 25 mars 2020 06:05:22 UTC-4, Sanskar Jaiswal a écrit : >> >> Hey Simon >> >> Just so that I am more clear, is it favourable to move all logic that >> ModelOperations and FieldOperations implement right now to ProjectState and >> ModelState? >> >> Kind regards >> Sanskar >> >> On Tue, 24 Mar 2020 at 04:20, Sanskar Jaiswal <jaiswal....@gmail.com> >> wrote: >> >>> Hey Simon, >>> >>> Thank you for your feedback! It helps a lot. I shall look into your >>> doubts right now, and edit my proposal accordingly. >>> >>> Kind regards >>> >>> Sanskar >>> >>> On Tue, Mar 24, 2020 at 3:37 AM charettes <char...@gmail.com> wrote: >>> >>>> Hello Sanskar, >>>> >>>> Thank you for your submission, from a quick look it seems to be heading >>>> in the right direction. >>>> >>>> Would it be possible to break the large overview section into more >>>> granular sections where you describe how you roughly plan to tackle each of >>>> the point mention? >>>> >>>> I personally have doubts about your desire to make minimal change to >>>> the schema editor and offload the logic to database_forwards instead of the >>>> other way around. That doesn't seem to be in line with a future deprecation >>>> of support for direct model passing. I'd much rather see us move all >>>> methods to (project_state, model_state, *other_state, >>>> **other_fields_and_flags) signatures and provide helpers to help >>>> third-party backends migrate (e.g. a method decorator that renders mode) >>>> then embedding logic for both paths in the schema editor and adding schema >>>> specific logic to Operation.database_forwards. >>>> >>>> Simon >>>> >>>> Le lundi 23 mars 2020 12:59:55 UTC-4, Sanskar Jaiswal a écrit : >>>>> >>>>> Hey everyone, >>>>> >>>>> Here is my proposal for GSoC. My project is based upon making use of >>>>> ModelState during the migrated phase of the project, rather than rendering >>>>> fake Models. >>>>> >>>>> https://gist.github.com/aryan9600/b1c2eaf445006c17e02e7677cf1098d5 >>>>> >>>>> Feedback and criticism is highly appreciated. >>>>> >>>>> Thanks! >>>>> Kind regards >>>>> Sanskar >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django developers (Contributions to Django itself)" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-d...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-developers/8e9a5959-d677-456f-9bb8-953e68162562%40googlegroups.com >>>> <https://groups.google.com/d/msgid/django-developers/8e9a5959-d677-456f-9bb8-953e68162562%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/fbf6ba88-2adc-4dd7-ac82-ecea6d1be313%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/fbf6ba88-2adc-4dd7-ac82-ecea6d1be313%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACzaa%3DGtC%2BqnUu%3DVfm4zXpL%2BCRqJa8JP0EyREKc7LVJOLzbq-Q%40mail.gmail.com.
