#20631: The max length of the email is 254
-------------------------------------+-------------------------------------
Reporter: pmartin | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):
* cc: marc.tamlyn@… (added)
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1
* stage: Accepted => Unreviewed
Comment:
I think that the change to the email validator is a good idea - the regex
should be more accommodating.
I am definitely -1 on introducing a new setting, and I think that at this
time we should not be changing the defaults for existing field types until
we can change it in the model layer as well. The documentation for
EmailField
(https://docs.djangoproject.com/en/dev/ref/models/fields/#emailfield)
already gives warnings about this.
In any case, it needs tests.
What Russ says about using the `check` command - I wonder whether it would
be worth in the future looking to extend it to have a "recommendations"
mode - highlights things like slug fields with no uniqueness condition,
email fields which don't have the length overridden etc. `--best-
practices` basically.
--
Ticket URL: <https://code.djangoproject.com/ticket/20631#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.9e7a59a337e66367fcb9e54c296df2af%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
