#20631: The max length of the email is 254
-------------------------------------+-------------------------------------
     Reporter:  pmartin              |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:
     Keywords:                       |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by pmartin):

 Replying to [comment:5 mjtamlyn]:
 > Personally I don't think it's worth making changes to the form field now
 when we can make changes to the model field once migrations lands (which
 is on its way). I'd love it to be right, but I don't think it's worth
 having an intermediary step when the "real" fix is probably going to be in
 Django 1.7 anyway.
 >

 I updated the [https://github.com/django/django/pull/1292/files#L4R529
 pull request], I had improve the code. Now the
 [https://github.com/django/django/pull/1292/files#L4R529 pull request] is
 very very simple.

 I have changed the
 [https://github.com/django/django/pull/1292/files#L4R529 form field]
 because now (django master) if you have a forms.EmailField in a form the
 max length is not validated. Of the same way that in
 [https://github.com/django/django/pull/1292/files#L3L989
 dbfield.EmailField]. Something like this:

 {{{

     class MyUserForm(forms.ModelForm):

         email_no_validate = forms.EmailField()

         class Meta:
             model = User
             fields = ('email', 'email_no_validate')


 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20631#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ad266bf1bd5add377b69aa671eeae577%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to