#20625: Custom Chainable QuerySets
-------------------------------------+-------------------------------------
     Reporter:  danols               |                    Owner:  loic84
         Type:  New feature          |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  QuerySet,            |      Needs documentation:  1
  models.Manager, chainable          |  Patch needs improvement:  1
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  1                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------

Comment (by loic84):

 The only issue I can think of is that we would override the `Manager`
 method when its is defined on both.

 I've just addressed that in
 https://github.com/loic/django/commit/b1d6d2a0cbdb5ad7decc2cf6fc8b8dde960061cf.

 I previously shielded `Manager.all()` from this issue with `manager=False`
 so it's no longer necessary. I believe `Manager.all()` and
 `RelatedManager.create()|get_or_create()` are in the situation you've
 described and it seems to work well.

 I'll start working on an RFC patch, hopefully I'll get pretty close by
 tonight.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20625#comment:26>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d6070e277833bc3971acd947c62d8328%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to