#21164: get_user_model() does not handle custom user models for testing purposes
-----------------------------------+---------------------------------------
     Reporter:  raymond.penners@…  |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  contrib.auth       |                  Version:  1.6-alpha-1
     Severity:  Release blocker    |               Resolution:
     Keywords:                     |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+---------------------------------------

Comment (by carljm):

 I didn't realize that the custom-user docs recommended this approach for
 testing. I was under the impression (from discussion in #7835) that models
 in test files being installed for test runs (only) was an undocumented
 accident of implementation, not a supported feature. (In any case, the new
 runner still supports it -- still only as an accident of implementation --
 but only in test files that are actually being run, which can differ with
 the new runner, as observed here.)

 I think the best solution for 1.6 is to no longer recommend reusing models
 from the auth tests, and instead recommend that people create their own
 custom user model if they need to test with one. A note about this could
 also be added to the release-notes backwards-incompatibility section about
 the new test runner.

 I think the only kinds of apps that need to be writing tests against
 various AUTH_USER_MODEL settings are reusable ones, and personally I think
 for testing reusable apps it's more robust to put your test models in a
 models.py of a test-only (sub)app, which you include in the INSTALLED_APPS
 setting in the standalone script that runs your reusable app's tests.
 (Instead of relying on the "models in test files" behavior.) This approach
 doesn't let you run the reusable app's tests from a "real project", but
 the discovery runner already discourages doing that anyway.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21164#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.9933209e577bdb6ee461186901dab034%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to