#25407: Remove network dependency in GeoIP tests
--------------------------------------+------------------------------------
Reporter: MarkusH | Owner: bak1an
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by berkerpeksag):
Instead of mocking `socket.gethostbyname()`(the IP can be changed), you
can skip the test if there is a transient failure. CPython uses the
following helper:
https://hg.python.org/cpython/file/default/Lib/test/support/__init__.py#l1294
The API could be better, of course.
--
Ticket URL: <https://code.djangoproject.com/ticket/25407#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.b9dcd231ae53304d95b904193e3dece8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
