#25407: Remove network dependency in GeoIP tests
--------------------------------------+------------------------------------
Reporter: MarkusH | Owner: bak1an
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by timgraham):
Thanks for the suggestion Berker, but in this case the IP of the website
isn't important for the purposes of the test (other than it must be in the
tested country/city), so actually I think the mocking approach is better
because we don't have to worry if the website does relocate their server
outside of the given test country/city (of course the IP could be
reassigned geographically too, but at that point we just have to update
the test).
--
Ticket URL: <https://code.djangoproject.com/ticket/25407#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.7f78eea2f1ec66e5d5651625f89eb4b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
