#26843: empty_label argument on ModelChoiceField is not tested -------------------------------------+------------------------------------- Reporter: smarlowucf | Owner: Type: | smarlowucf Cleanup/optimization | Status: assigned Component: Testing framework | Version: master Severity: Normal | Resolution: Keywords: | Triage Stage: ModelChoiceField,Tests,empty_label | Unreviewed Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 1 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by timgraham): I'd say there's insufficient test coverage if you can break one of the use cases you mentioned while keeping the current test suite passing. Did you try looking at git history where the code was introduced to see what tests were introduced at that time (5663258de13975e28406233328a9e51c8bc1b768 for example)? -- Ticket URL: <https://code.djangoproject.com/ticket/26843#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/068.2ee922c0e7290e73d684b0f926d327f8%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.