#26843: empty_label argument on ModelChoiceField is not tested
-------------------------------------+-------------------------------------
Reporter: smarlowucf | Owner:
Type: | smarlowucf
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
ModelChoiceField,Tests,empty_label | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by smarlowucf):
After further investigation:
The case where `empty_label` is set to `None` is indeed covered in tests
for `ModelMultipleChoiceField`. This is because `None` is forced for
`empty_label`.
[https://github.com/django/django/blob/master/tests/model_forms/tests.py#L2449
This assertion would fail if an empty choice was available].
For the second use case, forcing a random string if `empty_value` is not
`None` and `empty_value` is not the default string, causes one error.
{{{
if empty_label and empty_label != "---------":
self.empty_label = "Django"
}}}
[https://github.com/django/django/blob/master/tests/modeladmin/tests.py#L482
test_foreign_key_as_radio_field] fails because it's expecting an empty
value of `('', 'None')` but instead gets `('', 'Django')`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26843#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.afca14d296b6b46977d98ae44c021740%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
