#10061: incorrect logout link in admin
-------------------------------------------+--------------------------------
Reporter: lashni | Owner: mtredinnick
Status: new | Milestone: 1.1
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 1 |
-------------------------------------------+--------------------------------
Comment (by russellm):
Replying to [comment:62 russellm]:
> Replying to [comment:59 Alex]:
> > Couples thoughts:
> >
> > 2) I don't think Rob's fix for the split() error is correct, reversing
a function itself is legal, there should be a conditional arround the
view.split() line in the event it isn't a basestring.
>
> What evidence can you provide to support this assertion, Alex? As best
as I can make out, the line that Rob has identified has historically
fallen through to the NoReverseMatch exception, rather than being handled
as a callable.
For my next trick, I will put my entire lower leg into my mouth.
Apologies, Alex - you are correct: a callable should be allowed to
reverse, the docs say so, and so do the comment tests (hence the 18
errors). I'm about to attach a patch that passes the full test suite.
--
Ticket URL: <http://code.djangoproject.com/ticket/10061#comment:64>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
