#10061: incorrect logout link in admin
-------------------------------------------+--------------------------------
Reporter: lashni | Owner: mtredinnick
Status: new | Milestone: 1.1
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 1 |
-------------------------------------------+--------------------------------
Comment (by russellm):
Replying to [comment:72 ramiro]:
> Russell: (simple nitpick) If the user isn't supposed to modify the
`app_name` and `name` attibutes inside
[http://github.com/freakboy3742/django/blob/bfd2a9fbc5f508684949be5689bf82688e568be0/django/contrib/admin/sites.py#L185
AdminSite.get_urls()], wouldn't it be better to leave it to return an
urlpattern collection as it does currently and make the `urls` method
return `self.get_urls(), self.app_name, self.name`?.
>
> This would simplfy the admin customization API and would keep the method
consistent with its `ModelAdmin` counterpart.
Good idea, Ramiro. I've made this change on Github. I'm about to upload a
new patch to reflect all the recent changes for those that aren't git-
enabled.
--
Ticket URL: <http://code.djangoproject.com/ticket/10061#comment:74>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
