#13514: Only last package javascript catalog is loaded in case of missing
default
translation.
-------------------------------------------+--------------------------------
Reporter: jtiai | Owner: nobody
Status: new | Milestone: 1.2
Component: Internationalization | Version: SVN
Resolution: | Keywords: i18n javascript
Stage: Accepted | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by ramiro):
Replying to [comment:1 arkx]:
> I fixed this by setting a flag if English translation files could not be
found during the catalog's construction and checking for that flag when at
the last step the system is looking for active language's translation
files and the language happens to be English. Then and only then is the
catalog that had been set to LANGUAGE_CODE in previous step discarded.
Note that '''nothing is discarded unless the English translation files are
missing and English is the currently activated language choice''', which
should not happen if a browser requests the Finnish translation.
So far I've found that undoing the
[http://code.djangoproject.com/changeset/13069#file0 change] to
`django/views/i18n.py:javascript_catalog()` from r13069 makes the tests
pass as someone suggested above, both the ones added to this ticket and
even the ones added in that same commit. The full suite run successfully
too.
arkx:
What I'd like to understand and make sure we are handling correctly is
that `en_catalog_missing` flag. Currently we are setting it to True when
''at least'' one of the Python packages contained in the ''packages''
parameter has no English `.mo` file. This means the LANGUAGE_CODE
translations will be discarded in such case. Is this correct?
--
Ticket URL: <http://code.djangoproject.com/ticket/13514#comment:8>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
