#15954: Django's ignorable 404 list should include iphone favicons
---------------------------------------+------------------------------
               Reporter:  PaulM        |          Owner:  aaugustin
                   Type:  New feature  |         Status:  new
              Milestone:               |      Component:  Core (Other)
                Version:  1.3          |       Severity:  Normal
             Resolution:               |       Keywords:  middleware
           Triage Stage:  Accepted     |      Has patch:  1
    Needs documentation:  0            |    Needs tests:  0
Patch needs improvement:  1            |  Easy pickings:  0
---------------------------------------+------------------------------
Changes (by lukeplant):

 * needs_better_patch:  0 => 1
 * type:  Cleanup/optimization => New feature


Comment:

 Good work, here's my review:

 Even though it is trivial to replace IGNORABLE_404_STARTS/ENDS with
 IGNORABLE_404_URLS, our deprecation/backwards compatibility policy means
 we should keep supporting the former until we completely remove them two
 versions later. This is consistent with how we've handled `DATABASE_*` ->
 DATABASES (which is actually a simpler change as it doesn't change
 functionality).

 So we need the existing settings to carry on working. We should also emit
 a `PendingDeprecation` warning if they are non-empty.

 We also need this adding to the deprecation timeline under Django 1.6.

 One nit in documentation:  "of if you want to keep the old default value"
 should start **or** not **of**.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/15954#comment:5>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to