#15954: Django's ignorable 404 list should include iphone favicons
---------------------------------------+------------------------------
Reporter: PaulM | Owner: aaugustin
Type: New feature | Status: new
Milestone: | Component: Core (Other)
Version: 1.3 | Severity: Normal
Resolution: | Keywords: middleware
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
---------------------------------------+------------------------------
Changes (by aaugustin):
* needs_better_patch: 1 => 0
Comment:
Here is a new patch that implements the deprecation path.
In fact, there are two places where we could raise the
`PendingDeprecationWarning`:
- when the settings are used: this is what I have done. A warning will be
emitted for every 404 when `SEND_BROKEN_LINK_EMAILS` is `True` and `DEBUG`
is `False`. It will be written in the server log.
- when the settings are loaded: this would be a bigger change. In
`django/conf/__init__.py`, we would emit the warning, compile
`IGNORABLE_404_STARTS/ENDS` to regexps and append them to
`IGNORABLE_404_URLS`. It has the advantage that the warning will also be
visible under `./manage runserver`, but I am not sure it is worth it.
There is still one backwards-incompatible change that will immediately
appear in 1.4: the default value changes. Arguably, it's a bug fix.
--
Ticket URL: <http://code.djangoproject.com/ticket/15954#comment:6>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
