#16412: Disabling an 'django.contrib.sites' app, causes Try disabling an
'django.contrib.sites' app, (which as it is a contrib app, should be an
optional), and you'll get an error in tests with
django.contrib.auth.tests.forms.PasswordResetFormTest
-------------------------------------+-------------------------------------
Reporter: haras | Owner: nobody
Type: | Status: reopened
Cleanup/optimization | Component: contrib.auth
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* has_patch: 0 => 1
* type: Bug => Cleanup/optimization
* severity: Release blocker => Normal
* easy: 1 => 0
* stage: Unreviewed => Accepted
Comment:
`django.contrib.auth` uses the `get_current_site` method of
`django.contrib.sites`, which is safe to use, whether the sites framework
is or isn't enabled.
However, when the sites framework isn't enabled, this method must receive
the `request` in argument. In `test_custom_email_subject`, there is no
request available, and the test crashes. Attached patch fixes this (and
avoids relying on the default name of the default site).
--
Ticket URL: <https://code.djangoproject.com/ticket/16412#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
