#16412: Disabling an 'django.contrib.sites' app, causes Try disabling an
'django.contrib.sites' app, (which as it is a contrib app, should be an
optional), and you'll get an error in tests with
django.contrib.auth.tests.forms.PasswordResetFormTest
-------------------------------------+-------------------------------------
Reporter: haras | Owner: nobody
Type: | Status: reopened
Cleanup/optimization | Component: contrib.auth
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Ready for | Needs tests: 0
checkin | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
True, I had been a bit too quick in my initial judgment and there is no
need to write a test here. aaugustin made a good analysis of the issue and
the patch seems reasonable. Also the `domain_override` attribute doesn't
seem to be tested yet so that will increase the test suite's coverage. A
comment should just be added to that line of code explaining that
`domain_override` needs to be provided in the absence of a request object
in case `contrib.sites` isn't installed -- this can be done on commit.
--
Ticket URL: <https://code.djangoproject.com/ticket/16412#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
