#18347: Unit tests contain raw inserts to an identity column
-------------------------------------+-------------------------------------
     Reporter:  manfre               |                    Owner:  manfre
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  identity             |      Needs documentation:  0
  insert,mssql                       |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


Comment:

 The patch looks pretty good to me.

 However, wouldn't it be just as easy to not include the primary key in the
 inserted values in these two tests? I wouldn't like to expand the database
 backend API more than necessary.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18347#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to