#10790: Too many joins in a comparison for NULL.
-------------------------------------+-------------------------------------
     Reporter:  mtredinnick          |                    Owner:
         Type:  Bug                  |  mtredinnick
    Component:  Database layer       |                   Status:  new
  (models, ORM)                      |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by akaariai):

 The patch might be correct... The join promotion & trimming logic is so
 hard to follow that it is very, very hard to say :)

 But, if the tests pass it is a good indication this patch is on the right
 track.

 There are a couple of other patches floating around which concentrate on
 excludes & join promotion. I have to see if there is anything there which
 would be useful for this case.

 In whole the join promotion & trimming code would need some better
 comments about why things are done, and this should be from high-level
 perspective. It is really hard to see what is happening currently... I
 wonder if there is some more general trick we need to allow easier logic
 for join pruning (like, deferring all the pruning to pre-sql stage.

 I think pushing this to 1.4 is OK. A regression from 1.3 to 1.4 qualifies
 as a reason to push this into 1.4.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/10790#comment:24>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to