#10790: Too many joins in a comparison for NULL.
-------------------------------------+-------------------------------------
     Reporter:  mtredinnick          |                    Owner:
         Type:  Bug                  |  mtredinnick
    Component:  Database layer       |                   Status:  new
  (models, ORM)                      |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by akaariai):

 To get this committed to HEAD:
   - Provide more comments about what does a demoted join mean and when and
 why that is used.
   - Check the comments in sql/query.py, some of them seem to not be
 accurate.
   - Split the added tests to more than one method. The added method is
 200+ lines.
   - There is one failing test in queries after I applied the patch to
 HEAD.

 To get this committed to 1.4:
   - Get the patch committed to HEAD first.
   - Provide another patch to 1.4 (preferrably as a github branch).

 Even if you do that all, I can't guarantee the inclusion of this patch. As
 said the logic in the query class is very complex, and currently I don't
 understand what the patch does. Without understanding the patch it is hard
 to say if this is the right way...

 The HEAD-rebased patch can be found from:
 https://github.com/akaariai/django/tree/ticket_10790

-- 
Ticket URL: <https://code.djangoproject.com/ticket/10790#comment:26>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to