#19401: 'swapped' checking does not account for case insensitivity
-------------------------------------+-------------------------------------
Reporter: chris@… | Owner: nobody
Type: Bug | Status: reopened
Component: Database layer | Version:
(models, ORM) | 1.5-beta-1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by ptone):
Replying to [comment:11 chriscog]:
> I've put the changes into a github fork and sent a pull request:
https://github.com/django/django/pull/588
>
> That appropriate?
So using a pull request is completely appropriate - but I have to let you
know that changing the value of the flag from {{{swapped}}} to
{{{is_swapped}}} was completely unnecessary and will cause many reviewers
give your patch less consideration. Likewise the change from property to
attribute is not related to this ticket. These are design stylistic
choices one gets to make when writing the original feature, not to rehash
while working on a bugfix patch. I hope you take that as constructive
feedback - your efforts to give this issue some significant thought are
appreciated.
The main issue at hand is to remove a confusing result with a new feature
when, what is likely to be a relatively common honest mistake, is made.
That means raising a clearer error in cases where the setting is incorrect
- or allowing a looser (case insensitive object name) test of the swapped
model.
My own choice would be to allow for the looser test, but I'm going to
defer to Russ on the determination of the severity of this issue, and its
best resolution.
I have worked up a more lightweight fix using the case insensitive
approach (with a test) here:
https://github.com/ptone/django/compare/swapped-case
--
Ticket URL: <https://code.djangoproject.com/ticket/19401#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
