#19401: 'swapped' checking does not account for case insensitivity
-------------------------------------+-------------------------------------
     Reporter:  chris@…              |                    Owner:  nobody
         Type:  Bug                  |                   Status:  reopened
    Component:  Database layer       |                  Version:
  (models, ORM)                      |  1.5-beta-1
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by chriscog):

 Your concerns are understood. Soon after I made those changes, I realised
 that a far simpler one would be to keep just the one attribute, "swapped".

 However, I'm adamant that turning swapped from a function into an
 attribute that is calculated _once_ during Options.contribute_to_class()
 is the better (and much more efficient) way of handling it. I'll create
 another pull request with that variation and I'll take my chances :)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/19401#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to