On Wed, 30 Jul 2014, Greg Bailey wrote:
> I've filed a formal review request at:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1124994
a current rpmlint run ...
Please amend to remove the 'dl' in the indicate places
[herrold@centos-6 dl]$ rpmlint dl-0.12-1.orc6.src.rpm
dl.src: W: summary-not-capitalized C dl: Download Ticket
Service
dl.src: W: name-repeated-in-summary C dl
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[herrold@centos-6 dl]$
binaries
[herrold@centos-6 dl]$ rpmlint
/home/herrold/rpmbuild/RPMS/noarch/dl-0.12-1.orc6.noarch.rpm
dl.noarch: W: summary-not-capitalized C dl: Download Ticket
Service
dl.noarch: W: name-repeated-in-summary C dl
dl.noarch: W: incoherent-version-in-changelog 0.12-1
['0.12-1.orc6', '0.12-1.orc6']
dl.noarch: E: htaccess-file
/usr/share/dl/style/include/.htaccess
perhaps name this as a:
/usr/share/dl/style/include/.htaccess-template
dl.noarch: E: incorrect-fsf-address
/usr/share/dl/include/gettext/streams.php
patch needed upstream at dl
dl.noarch: E: incorrect-fsf-address
/usr/share/dl/include/gettext/gettext.inc
and again
dl.noarch: E: version-control-internal-file
/usr/share/doc/dl-0.12/client/thunderbird-filelink-dl/.gitignore
rm the indicated file from inclusion in the packaging
dl.noarch: E: incorrect-fsf-address
/usr/share/dl/include/gettext/gettext.php
as above
dl.noarch: E: htaccess-file /usr/share/dl/include/.htaccess
as above -- a rename
dl.noarch: E: non-standard-dir-perm /var/spool/dl 0770L
interesting -- I would expect 1777 here -- is there an
unsafe directory issue we had missed
dl.noarch: W: doc-file-dependency
/usr/share/doc/dl-0.12/client/thunderbird-filelink-dl/build.sh
/bin/bash
this should be whitelisted, but /bin/sh is o course
portable -- can it be changed to such
dl.noarch: W: dangerous-command-in-%post chown
perhaps handle in a %files section
1 packages and 0 specfiles checked; 7 errors, 5 warnings.
[herrold@centos-6 dl]$
