On 11/26/2012 04:18 PM, Gene Czarcinski wrote:
On 11/26/2012 03:22 PM, John Brendler wrote:
Hi Gene,
Instead of deprecating/turning-off logging by facility, it would be
better to have ability to tune loglevel for each sysbsystem.
Like following: where 0 means
log-level=dhcp,dhcpv6,6,dns,7,ra,-1
Best Regards, Vladislav Grishenko
++
Recording or ignoring certain messages is the function of a syslog
daemon. If people are annoyed by certain log messages, they can
resolve that within syslog.
You are correct and most of the time "too many messages" is a matter
of proper filtering. However, you need something to differentiate
messages also.
Having said that, I agree that highly granular configurability of
logging within dnsmasq would be useful, but setting loglevel by dnsmasq
function (e.g. dhcp, dns, etc.) may not be the answer. As Gene said,
errors and warnings should always be logged.
I believe that dnsmasq makes good use of WARNING, ERR, and CRIT
messages but INFO amy be a bit overpopulated. When you are
troubleshooting, there is no such thing as too many messages but I do
believe that there needs to be a little more to differentiate all of
the INFO messages.
Maybe the essence of the problem is simply that the loglevel for RA
type messages is at an inappropriate level (e.g., is at "notice" (5) or
"info" (6) loglevel when maybe it should be at "debug" (7) loglevel. I
think that may be enough of a solution.
Now, as far as the RA related messages, the problem really boils down
to the "RTR-ADVERT" messages and those should be LOG_DEBUG. Making
that change would scratch my itch.
This is likely unnecessary but here is the patch.
Gene
diff -urp dnsmasq-2.64rc1-orig.1/src/radv.c dnsmasq-2.64rc1/src/radv.c
--- dnsmasq-2.64rc1-orig.1/src/radv.c 2012-11-14 09:12:56.000000000 -0500
+++ dnsmasq-2.64rc1/src/radv.c 2012-11-26 16:30:16.352050345 -0500
@@ -420,7 +420,7 @@ static int add_prefixes(struct in6_addr
opt->prefix = *local;
inet_ntop(AF_INET6, local, daemon->addrbuff, ADDRSTRLEN);
- my_syslog(MS_DHCP | LOG_INFO, "RTR-ADVERT(%s) %s", param->if_name, daemon->addrbuff);
+ my_syslog(MS_DHCP | LOG_DEBUG, "RTR-ADVERT(%s) %s", param->if_name, daemon->addrbuff);
}
}
}
_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
