On 26.04.2018 19:03, Simon Kelley wrote:

        
General questions:
- Is there any reason to not use the `enum` for definition lists like
`LOPT_*`?
No strong ones, just habit I guess.
Can this be refactored to simplify the code?
It can be refactored, yes, but it probably won't simplify things.

Not having to count manually is a simplification and it avoids mistakes.
Please check out my patch for introducing enums:

https://github.com/digineo/dnsmasq/compare/enums

Regards
Julian


_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Reply via email to