OK, I removed the limit, but added a big logged warning if you exceed it....



Cheers,

Simon.


On 09/05/18 13:00, Dominik DL6ER wrote:
> [PATCH] Remove upper limit of 10,000 for cache size
> 
> Signed-off-by: Dominik Derigs <dl...@dl6er.de>
> ---
>  src/option.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/option.c b/src/option.c
> index 65df93a..180517a 100644
> --- a/src/option.c
> +++ b/src/option.c
> @@ -2589,8 +2589,6 @@ static int one_opt(int option, char *arg, char
> *errstr, char *gen_err, int comma
>            
>             if (size < 0)
>               size = 0;
> -           else if (size > 10000)
> -             size = 10000;
>            
>             daemon->cachesize = size;
>           }
> -- 2.7.4
> 
> 
> On 09.05.2018 13:13, Geert Stappers wrote:
>> ---
>>  man/dnsmasq.8    | 2 +-
>>  man/es/dnsmasq.8 | 3 ++-
>>  man/fr/dnsmasq.8 | 3 ++-
>>  3 files changed, 5 insertions(+), 3 deletions(-)
>>
>> Note that this patch contains non-ASCII characters,
>> those might be mangled during transport ...
>>
>>
>> diff --git a/man/dnsmasq.8 b/man/dnsmasq.8
>> index 21069de..7664e06 100644
>> --- a/man/dnsmasq.8
>> +++ b/man/dnsmasq.8
>> @@ -692,7 +692,7 @@ will add 1.2.3.0/24 for both IPv4 and IPv6 requestors.
>>  
>>  .TP
>>  .B \-c, --cache-size=<cachesize>
>> -Set the size of dnsmasq's cache. The default is 150 names. Setting the 
>> cache size to zero disables caching.
>> +Set the size of dnsmasq's cache. The default is 150 names. Setting the 
>> cache size to zero disables caching. Note: huge cache size impacts 
>> performance.
>>  .TP
>>  .B \-N, --no-negcache
>>  Disable negative caching. Negative caching allows dnsmasq to remember
>> diff --git a/man/es/dnsmasq.8 b/man/es/dnsmasq.8
>> index 81c745a..4a70a4f 100644
>> --- a/man/es/dnsmasq.8
>> +++ b/man/es/dnsmasq.8
>> @@ -478,7 +478,8 @@ la traza reversa direcci
>>  .TP
>>  .B \-c, --cache-size=<tama�o de cach�>
>>  Fijar el tama�o del cach� de dnsmasq. El predeterminado es 150 nombres.
>> -Fijar el tama�o a cero deshabilita el cach�.
>> +Fijar el tama�o a cero deshabilita el cach�. Nota: el gran tama�o de
>> +cach� afecta el rendimiento.
>>  .TP
>>  .B \-N, --no-negcache
>>  Deshabilitar cach� negativo. El cach� negativo le permite a dnsmasq
>> diff --git a/man/fr/dnsmasq.8 b/man/fr/dnsmasq.8
>> index 80cef39..d3c05b8 100644
>> --- a/man/fr/dnsmasq.8
>> +++ b/man/fr/dnsmasq.8
>> @@ -666,7 +666,8 @@ différentes pourraient-être rencontrés, alors le cache 
>> devrait être désacti
>>  .TP
>>  .B \-c, --cache-size=<taille>
>>  Définit la taille du cache de Dnsmasq. La valeur par défaut est de 150 noms.
>> -Définir une valeur de zéro désactive le cache.
>> +Définir une valeur de zéro désactive le cache. Remarque: la taille 
>> importante
>> +du cache a un impact sur les performances.
>>  .TP
>>  .B \-N, --no-negcache
>>  Désactive le "cache négatif". Le "cache négatif" permet à Dnsmasq de se 
>> souvenir
>>
>>
>> _______________________________________________
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss@lists.thekelleys.org.uk
>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 


_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Reply via email to