On 25/10/2018 09:36, Petr Mensik wrote: > Hi again. > > This time I have a little bit more controversal patches. But I think > still useful. They fixes memory leaks that might occur in some cases. > Most dnsmasq errors is fatal, so it does not matter. But some are not. > Some parts are reloaded on SIGHUP signal, so it might leak more than once. > > Some example when it changes the failures. Use dhcp-options file with > this content: > > tag:error,vendor:redhat > option:ntp-server,1.2.3.4.5 > option6:ntp-server,[:::] > > Is not fatal and dnsmasq will start. On each reload command, it would > leak some memory. I validated it using valgrind --leak-check=full > dnsmasq -d. This patch fixes it. It introduces something that might be > considered constructor and destructor of selected structures. What do > you think of it? > > Comments are welcome. Another patch would be sent short after, they are > too big together to require moderator attention. >
I've applied the patches. I think they're doing the right thing. I'm a little bit concerned about how extensive the changes are, but I've done my best to review everything, and I can't find any problems. We're early in the 2.81 cycle, so if there is anything lurking, there's a chance to find it. Cheers, Simon. _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss