On Thu, Jun 19, 2014 at 04:01:44PM +0800, Liu Ying wrote:
> The following list empty check is unnecessary because we would still do
> nothing
> real and return 'val' if my_list is empty.
>
> if (list_empty(&my_list))
> return val;
>
> list_for_each_entry(pos, &my_list, member) {
> ...
> }
>
> return val;
>
> This patch removes the unnecessary check in drm_fb_helper_debug_enter().
>
> Signed-off-by: Liu Ying <Ying.Liu at freescale.com>
Merged into my core-stuff branch, will send a pull to Dave for 3.17.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_helper.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index d5d8cea..eb77a2f 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -199,9 +199,6 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
> struct drm_crtc_helper_funcs *funcs;
> int i;
>
> - if (list_empty(&kernel_fb_helper_list))
> - return false;
> -
> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
> for (i = 0; i < helper->crtc_count; i++) {
> struct drm_mode_set *mode_set =
> --
> 1.7.9.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
