On Wed, Nov 19, 2014 at 03:13:20PM +0100, Julien CHAUVEAU wrote: > We need to call clk_put on display clock, in the same way as functional clock. > > Signed-off-by: Julien CHAUVEAU <julien.chauveau at neo-technologies.fr> > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 79a34cb..ccc1cdb 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -136,6 +136,9 @@ static int tilcdc_unload(struct drm_device *dev) > CPUFREQ_TRANSITION_NOTIFIER); > #endif > > + if (priv->disp_clk) > + clk_put(priv->disp_clk); > + > if (priv->clk) > clk_put(priv->clk);
we should actually remove the priv->$clk check. clk_put() is safe against NULL pointers. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20141119/43862d5e/attachment.sig>
