https://bugs.freedesktop.org/show_bug.cgi?id=37168

--- Comment #7 from Sean McNamara <gm.potato...@gmail.com> 2011-06-10 14:56:30 
PDT ---
(In reply to comment #6)
> Created an attachment (id=47812)
 View: https://bugs.freedesktop.org/attachment.cgi?id=47812
 Review: https://bugs.freedesktop.org/review?bug=37168&attachment=47812

> proposed patch
> 
> I'm having the same memory leak issue (though I kill the game when swapping
> starts so I did not experience kernel lock).
> 
> The attached patch seems to fix the problem; could you please test it with 
> your
> setup ?

Your patch fixes the problem here too! Great job spotting it!!

I am curious, what research process did you undertake in order to isolate the
leak? I would like to learn how to do that. I am a software engineer, but
apparently there's some tool I should know about that would help me narrow down
this kind of leak to a specific part of the code.

Anyway, I think you should really put this patch up for inclusion into git
master. I don't see any adverse effects from the patch, and it definitely
resolves the issue (I've run imprudence for 45 minutes and it's only using 3.8%
of my 6GB of memory, whereas before it would get OOM Killed within 5 minutes).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to