Hi Hyungwon, On 19 August 2015 at 01:58, Hyungwon Hwang <human.hwang at samsung.com> wrote: > This patch seprates the code, which sorts proprty sets and eliminates > duplicate properties, from drmModeAtomicCommit(). Now > drmModeAtomicCleanup() has to do the job before calling > drmModeAtomicCommit(), and drmModeAtomicCommit() just converts the cleaned > request to IOCTL argument. > Afaict the commit message should say why we want this, rather than rewording what the patch does.
I'm not sure about the atomic status for wayland and others but this commit might cause issues there. Additionally, with this patch we'll send a lot of useless information to the kernel if one omits drmModeAtomicCleanup(). The kernel will likely discard it but still this doesn't seem like a good idea imho. -Emil
