From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>

.atomic_begin() and .atomic_flush() allows to perform extra operations
before and after the update of planes. For FIMD for example this will
be used to enable disable the shadow protection bit.

Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk>

---
v2: rename prepare_plane/cleanup_plane to atomic_begin/atomic_flush
---
 drivers/gpu/drm/exynos/exynos_drm_crtc.c | 19 +++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_drv.h  |  6 ++++++
 2 files changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c 
b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
index 94eb831..54485b7 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -73,16 +73,35 @@ static void exynos_crtc_atomic_begin(struct drm_crtc *crtc,
                                     struct drm_crtc_state *old_crtc_state)
 {
        struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
+       struct drm_plane *plane;

        if (crtc->state->event) {
                WARN_ON(drm_crtc_vblank_get(crtc) != 0);
                exynos_crtc->event = crtc->state->event;
        }
+
+       drm_atomic_crtc_for_each_plane(plane, crtc) {
+               struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
+
+               if (exynos_crtc->ops->atomic_begin)
+                       exynos_crtc->ops->atomic_begin(exynos_crtc,
+                                                       exynos_plane);
+       }
 }

 static void exynos_crtc_atomic_flush(struct drm_crtc *crtc,
                                     struct drm_crtc_state *old_crtc_state)
 {
+       struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
+       struct drm_plane *plane;
+
+       drm_atomic_crtc_for_each_plane(plane, crtc) {
+               struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
+
+               if (exynos_crtc->ops->atomic_flush)
+                       exynos_crtc->ops->atomic_flush(exynos_crtc,
+                                                       exynos_plane);
+       }
 }

 static struct drm_crtc_helper_funcs exynos_crtc_helper_funcs = {
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h 
b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index a993aac..28afecc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -87,6 +87,8 @@ struct exynos_drm_plane {
  * @disable_vblank: specific driver callback for disabling vblank interrupt.
  * @wait_for_vblank: wait for vblank interrupt to make sure that
  *     hardware overlay is updated.
+ * @atomic_begin: prepare a window to receive a update
+ * @atomic_flush: mark the end of a window update
  * @update_plane: apply hardware specific overlay data to registers.
  * @disable_plane: disable hardware specific overlay.
  * @te_handler: trigger to transfer video image at the tearing effect
@@ -107,10 +109,14 @@ struct exynos_drm_crtc_ops {
        int (*enable_vblank)(struct exynos_drm_crtc *crtc);
        void (*disable_vblank)(struct exynos_drm_crtc *crtc);
        void (*wait_for_vblank)(struct exynos_drm_crtc *crtc);
+       void (*atomic_begin)(struct exynos_drm_crtc *crtc,
+                             struct exynos_drm_plane *plane);
        void (*update_plane)(struct exynos_drm_crtc *crtc,
                             struct exynos_drm_plane *plane);
        void (*disable_plane)(struct exynos_drm_crtc *crtc,
                              struct exynos_drm_plane *plane);
+       void (*atomic_flush)(struct exynos_drm_crtc *crtc,
+                             struct exynos_drm_plane *plane);
        void (*te_handler)(struct exynos_drm_crtc *crtc);
        void (*clock_enable)(struct exynos_drm_crtc *crtc, bool enable);
 };
-- 
2.1.0

Reply via email to