On Thu, Dec 03, 2015 at 06:30:10PM +0900, Inki Dae wrote:
> This patch updates a ports node binding for panel.
> 
> With this, dp node can have a ports node which describes
> a remote endpoint node that can be connected to panel or bridge
> node.
> 
> Signed-off-by: Inki Dae <inki.dae at samsung.com>
> ---
>  .../bindings/display/exynos/exynos_dp.txt          | 28 
> ++++++++++++++++++----
>  1 file changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt 
> b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
> index 64693f2..15b52cb 100644
> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
> @@ -66,8 +66,15 @@ Optional properties for dp-controller:
>               Hotplug detect GPIO.
>                       Indicates which GPIO should be used for hotplug
>                       detection
> -     -video interfaces: Device node can contain video interface port
> -                         nodes according to [1].
> +Video interfaces:
> +  Device node can contain video interface port nodes according to [1].
> +  The following are properties specific to those nodes:
> +
> +  endpoint node connected to bridge or panel node:
> +   - remote-endpoint: specifies the endpoint in panel or bridge node.
> +                   This node is required in all kinds of exynos dp
> +                   to represent the connection between dp and bridge
> +                   ,or dp and panel.

Fix your punctuation.

>  
>  [1]: Documentation/devicetree/bindings/media/video-interfaces.txt
>  
> @@ -111,9 +118,22 @@ Board Specific portion:
>               };
>  
>               ports {
> -                     port at 0 {
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;

You don't need these.

> +
> +                     port {
>                               dp_out: endpoint {
> -                                     remote-endpoint = <&bridge_in>;
> +                                     remote-endpoint = <&dp_in>;
> +                             };
> +                     };
> +             };
> +
> +             panel at 0 {
> +                     reg = <0>;

Drop the @0 and reg as you only have 1.

> +                     ...
> +                     port {
> +                             dp_in: endpoint {
> +                                     remote-endpoint = <&dp_out>;
>                               };
>                       };
>               };
> -- 
> 1.9.1
> 

Reply via email to