Hi Matthias, thanks for your reply. It would be helpful if you could trim the quoted text a bit when replying to a small part of a huge patch like this.
Am Freitag, den 11.12.2015, 18:10 +0100 schrieb Matthias Brugger: > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > new file mode 100644 > > index 0000000..a34c765 > > --- /dev/null > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -0,0 +1,562 @@ > > +/* > > + * Copyright (c) 2015 MediaTek Inc. > > + * Author: YT SHEN <yt.shen at mediatek.com> > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include <drm/drmP.h> > > +#include <drm/drm_atomic.h> > > +#include <drm/drm_atomic_helper.h> > > +#include <drm/drm_crtc_helper.h> > > +#include <drm/drm_gem.h> > > +#include <linux/component.h> > > +#include <linux/dma-iommu.h> > > Do we need this include here? No, thank you for noticing. Will be removed in the next version. best regards Philipp