On Mon, Jan 19, 2015 at 04:52:32PM +0900, Hyungwon Hwang wrote: > From: Inki Dae <inki.dae at samsung.com> > > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320Ã320 resolution in 1.63-inch physical panel. This panel is used in > Samsung Galaxy Gear 2. > > Signed-off-by: Inki Dae <inki.dae at samsung.com> > Signed-off-by: Hyungwon Hwang <human.hwang at samsung.com> > Acked-by: Kyungmin Park <kyungmin.park at samsung.com> > --- > Changes for v2: > - Change the gamma table to 2-dimensional array > - Change the way to make index for brightness > - Make command functions to an array so that it can be called simply > - Change command id for reading device ID > - Change the way to handle the error condition > - Remove power variable, and use the same name variable in bl_dev > - Add the state FB_BLANK_NORMAL to represent the state which the panel > is working but blanked > - Miscellaneous changes to increase the readability and follow the > coding-style standard > Changes for v3: > - Add DT binding documentation > - Add the code getting DT properties of 'panel-width-mm' and 'panel-height-mm' > - Remove the code getting unnecessary DT properties flip-* > .../bindings/panel/samsung,s6e63j0x03.txt | 55 +++ > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-s6e63j0x03.c | 546 > +++++++++++++++++++++ > 4 files changed, 608 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/panel/samsung,s6e63j0x03.txt > create mode 100644 drivers/gpu/drm/panel/panel-s6e63j0x03.c
I have pretty much the same comments as for the SA6E3HA2 panel driver that I reviewed earlier. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150203/d0edcc9d/attachment-0001.sig>