On 26/03/15 16:57, randyf at sibernet.com wrote: [...] >>> Alternatively can we: >>> (1) move the wrapper to xf86drmMode.h itself, or >>> (2) move this inline helper function out of xf86drmMode.h and into >>> the two libdrm tests that use it (or a shared test helper .h [0]) >>> (3) remove the inline and make drm_property_type_is a non-inline >>> function in xf86drmMode.c >>> >>> [0] I think Thierry already has a patch set that rearranges the tests >>> to use some shared headers. Perhaps this will work well once his set >>> lands. >>> >> Fwiw I would opt for 1 or 3 (leaning towards 1), as 2 might lead to: >> - Everyone coming up with their own "helper", or >> - Ignoring DRM_MODE_PROP_EXTENDED_TYPE checking >> drmModePropertyPtr::flags, thus causing all sorts of chaos. >> >> >> Randy, Niveditha, Stuart, >> >> Does the compiler(s) used to build libdrm and friends support __inline ? > > It should. I can't be 100% sure as there was just recently a new > compiler release, but I would also suspect if this support was broken or > dropped, then lots of stuff would break. > > Thanks for the information Randy.
Daniel Based Randy's input we can go with the original solution :-) Will leave the patch around for a week or so, for others to comment, before pushing it. If someone else beats me to it, feel free to add: Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com> Cheers, Emil
