On Sun, Jan 24, 2016 at 10:02:10PM +0530, Amitoj Kaur Chawla wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > to break out of the loop an of_node_put is required. > > Found using Coccinelle. The semantic patch used for this is as follows: > > // <smpl> > @@ > expression e; > local idexpression n; > @@ > > for_each_child_of_node(..., n) { > ... when != of_node_put(n) > when != e = n > ( > return n; > | > + of_node_put(n); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606 at gmail.com> > --- > drivers/gpu/host1x/bus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20160125/6d1a41b6/attachment-0001.sig>