[PATCH 06/10] drm: Drop cargo-culted modeset_lock_all from encoder/plane init/cleanup

[Daniel Vetter]

We can't hotplug encoders/planes, there's no point in that locking. It
was also inconsistent because lacking from plane_init.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 drivers/gpu/drm/drm_crtc.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 2a927488ec26..6a8f91e8821b 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1131,11 +1131,9 @@ int drm_encoder_init(struct drm_device *dev,
 {
        int ret;

-       drm_modeset_lock_all(dev);
-
        ret = drm_mode_object_get(dev, &encoder->base, DRM_MODE_OBJECT_ENCODER);
        if (ret)
-               goto out_unlock;
+               return ret;

        encoder->dev = dev;
        encoder->encoder_type = encoder_type;
@@ -1163,9 +1161,6 @@ out_put:
        if (ret)
                drm_mode_object_unregister(dev, &encoder->base);

-out_unlock:
-       drm_modeset_unlock_all(dev);
-
        return ret;
 }
 EXPORT_SYMBOL(drm_encoder_init);
@@ -1185,12 +1180,10 @@ void drm_encoder_cleanup(struct drm_encoder *encoder)
         * the indices on the drm_encoder after us in the encoder_list.
         */

-       drm_modeset_lock_all(dev);
        drm_mode_object_unregister(dev, &encoder->base);
        kfree(encoder->name);
        list_del(&encoder->head);
        dev->mode_config.num_encoder--;
-       drm_modeset_unlock_all(dev);

        memset(encoder, 0, sizeof(*encoder));
 }
@@ -1341,7 +1334,6 @@ void drm_plane_cleanup(struct drm_plane *plane)
 {
        struct drm_device *dev = plane->dev;

-       drm_modeset_lock_all(dev);
        kfree(plane->format_types);
        drm_mode_object_unregister(dev, &plane->base);

@@ -1356,7 +1348,6 @@ void drm_plane_cleanup(struct drm_plane *plane)
        dev->mode_config.num_total_plane--;
        if (plane->type == DRM_PLANE_TYPE_OVERLAY)
                dev->mode_config.num_overlay_plane--;
-       drm_modeset_unlock_all(dev);

        WARN_ON(plane->state && !plane->funcs->atomic_destroy_state);
        if (plane->state && plane->funcs->atomic_destroy_state)
-- 
2.8.1