Hi Ville,
Thank you for the patch.
On Thursday 17 Nov 2016 18:14:22 ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Get the format information via the neat fb->format pointer rather than
> doing a linear search over all the format info structures.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index 570f5c6063f3..0dc3f5bcbf48
> 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -304,15 +304,12 @@ EXPORT_SYMBOL_GPL(drm_fb_cma_prepare_fb);
> static void drm_fb_cma_describe(struct drm_framebuffer *fb, struct seq_file
> *m) {
> struct drm_fb_cma *fb_cma = to_fb_cma(fb);
> - const struct drm_format_info *info;
> int i;
>
> seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width, fb->height,
> (char *)&fb->pixel_format);
>
> - info = drm_format_info(fb->pixel_format);
> -
> - for (i = 0; i < info->num_planes; i++) {
> + for (i = 0; i < fb->fomat->num_planes; i++) {
> seq_printf(m, " %d: offset=%d pitch=%d, obj: ",
> i, fb->offsets[i], fb->pitches[i]);
> drm_gem_cma_describe(fb_cma->obj[i], m);
--
Regards,
Laurent Pinchart
