Hi Fabio, On 11/25/2016 02:29 PM, Fabio Estevam wrote: > Hi Vladimir, > > On Thu, Nov 24, 2016 at 8:16 PM, Vladimir Zapolskiy > <vladimir_zapolskiy at mentor.com> wrote: > >> By the way while we're discussing DW HDMI bindings specific to iMX, >> I would recommend to remove utterly hackish and iMX only "gpr" >> property from the example in bindings/display/bridge/dw_hdmi.txt > > What if we get rid of the "gpr" property completely? > > --- a/drivers/gpu/drm/imx/dw_hdmi-imx.c > +++ b/drivers/gpu/drm/imx/dw_hdmi-imx.c > @@ -99,9 +99,8 @@ static const struct dw_hdmi_phy_config imx_phy_config[] = { > > static int dw_hdmi_imx_parse_dt(struct imx_hdmi *hdmi) > { > - struct device_node *np = hdmi->dev->of_node; > + hdmi->regmap = > syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr"); > > - hdmi->regmap = syscon_regmap_lookup_by_phandle(np, "gpr"); > if (IS_ERR(hdmi->regmap)) { > dev_err(hdmi->dev, "Unable to get gpr\n"); > return PTR_ERR(hdmi->regmap); > > Then we can remove the gpr from the device tree files. >
according to the DTSI files in the vanilla kernel DW HDMI IP is found only on iMX6Q/D and iMX6DL/iMX6S SoCs (but please double check it), so this approach should work ideally. I see that the same has already been done in PCIe and SATA drivers, but please consider to send a similar change against iMX LDB driver including removal of the property from imx6qdl.dtsi and Documentation/devicetree/bindings/display/imx/ldb.txt. And back to DW HDMI IP it seems that after removing "gpr" property Documentation/devicetree/bindings/display/imx/hdmi.txt can be removed, because bindings/display/bridge/dw_hdmi.txt replaces it. -- With best wishes, Vladimir