On 31/08/16 16:14, Jyri Sarha wrote: > Write DMA base and ceiling address with a single instruction, if > available. This should make it more unlikely that LCDC would fetch the > DMA addresses in the middle of an update. Having bad combination of > addresses in dma base and ceiling (e.g base > ceiling) can cause > unpredictaple behavior in LCDC. > > Signed-off-by: Jyri Sarha <jsarha at ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +++++++-- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 14 ++++++++++++++ > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 6350f2a..41ec5b3 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -70,6 +70,7 @@ static void set_scanout(struct drm_crtc *crtc, struct > drm_framebuffer *fb) > struct drm_gem_cma_object *gem; > unsigned int depth, bpp; > dma_addr_t start, end; > + u64 dma_base_and_ceiling; > > drm_fb_get_bpp_depth(fb->pixel_format, &depth, &bpp); > gem = drm_fb_cma_get_gem_obj(fb, 0); > @@ -80,8 +81,12 @@ static void set_scanout(struct drm_crtc *crtc, struct > drm_framebuffer *fb) > > end = start + (crtc->mode.vdisplay * fb->pitches[0]); > > - tilcdc_write(dev, LCDC_DMA_FB_BASE_ADDR_0_REG, start); > - tilcdc_write(dev, LCDC_DMA_FB_CEILING_ADDR_0_REG, end - 1); > + /* Write DMA base and ceiling address with a single insruction, > + * if available. This should make it more unlikely that LCDC would > + * fetch the DMA addresses in the middle of an update. > + */
I think it would be good to have the register names mentioned in the above comment. Otherwise I can imagine grepping for CEILING_ADDR, and not finding it set anywhere in the driver... Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160901/78a50d5e/attachment.sig>
