On Thu, Sep 8, 2016 at 1:52 PM, Rob Herring <robh at kernel.org> wrote: > On Thu, Sep 1, 2016 at 2:08 PM, Christian Gmeiner > <christian.gmeiner at gmail.com> wrote: >> Hi Emil, >> >> thanks a lot for the review. >> >> 2016-08-30 15:03 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>: >>> On 30 August 2016 at 08:14, Christian Gmeiner >>> <christian.gmeiner at gmail.com> wrote: >>>> From: The etnaviv authors <dri-devel at lists.freedesktop.org> >>>> >>>> Add the libdrm_etnaviv helper library to encapsulate etnaviv-specific >>>> interfaces to the DRM. >>>> >>>> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com> >>>> Signed-off-by: Lucas Stach <l.stach at pengutronix.de> >>> Just double-checking: >>> - you've looked that all the relevant freedreno patches have been >>> ported over, correct ? >>> - the feature checking bug (mentioned on IRC) has been fixed ? >>> >>>> diff --git a/configure.ac b/configure.ac >>>> index e3048c7..64f3e6c 100644 >>>> --- a/configure.ac >>>> +++ b/configure.ac >>> >>>> @@ -274,6 +279,9 @@ if test "x$drm_cv_atomic_primitives" = "xnone"; then >>>> >>>> LIBDRM_ATOMICS_NOT_FOUND_MSG($TEGRA, tegra, NVIDIA Tegra, >>>> tegra-experimental-api) >>>> TEGRA=no >>>> + >>>> + LIBDRM_ATOMICS_NOT_FOUND_MSG($ETNAVIV, etnaviv, Vivante, >>>> etnaviv-experimental-api) >>> Reading this hunk reminds me what a bad name I've used. Then again >>> nothing better comes up atm. If you can think of any please shout. >>> >>>> +++ b/etnaviv/Android.mk >>> Have you tried building/using etna on Android ? >>> >> >> No.. if it is an easy job I would give it a try. Shall I drop it? > > But I have. libdrm just needs this patch (for master and N):
NM. I see you already have that change in this patch, so Android build should be fine. I'll give v2 patch a try. Rob
