The combo of list_empty() check and return list_first_entry()
can be replaced with list_first_entry_or_null().

Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
---

 drivers/gpu/drm/vc4/vc4_drv.h | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index 428e249..61c1902 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -307,18 +307,15 @@ struct vc4_exec_info {
 static inline struct vc4_exec_info *
 vc4_first_bin_job(struct vc4_dev *vc4)
 {
-       if (list_empty(&vc4->bin_job_list))
-               return NULL;
-       return list_first_entry(&vc4->bin_job_list, struct vc4_exec_info, head);
+       return list_first_entry_or_null(&vc4->bin_job_list,
+                                       struct vc4_exec_info, head);
 }

 static inline struct vc4_exec_info *
 vc4_first_render_job(struct vc4_dev *vc4)
 {
-       if (list_empty(&vc4->render_job_list))
-               return NULL;
-       return list_first_entry(&vc4->render_job_list,
-                               struct vc4_exec_info, head);
+       return list_first_entry_or_null(&vc4->render_job_list,
+                                       struct vc4_exec_info, head);
 }

 static inline struct vc4_exec_info *
-- 
1.9.1

Reply via email to