On Wed, Feb 01, 2017 at 12:50:48PM -0800, Eric Anholt wrote: > Gabriel Krisman Bertazi <kris...@collabora.co.uk> writes: > > > Instead of receiving the num_crts as a parameter, we can read it > > directly from the mode_config structure. I audited the drivers that > > invoke this helper and I believe all of them (but one, see below) > > initialize the mode_config struct accordingly, prior to calling the > > fb_helper. > > This is a nice cleanup! It always felt silly to be passing in my > mode_config's members to the fbdev setup. Could we do the same for > num_connector? > > I've verified that all the drivers either init their CRTCs or have > already looked at mode_config.num_crtcs before the fbdev init call, so > this is: > > Reviewed-by: Eric Anholt <e...@anholt.net>
Yeah, nice patch but doesn't apply now that Dave has pulled in a bunch of driver pull requests :( Can you pls regen the cocci, but pls keep Eric's r-b so I don't have to go hunting for it. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
