This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
---
 include/drm/drm_drv.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 9fe6301edd6a..0a367cf5d8d5 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -274,6 +274,11 @@ struct drm_driver {
         *     constant but unknown small number of scanlines wrt. real scanout
         *     position.
         *
+        * FIXME:
+        *
+        * Since this is a helper to implement @get_vblank_timestamp, we should
+        * move it to &struct drm_crtc_helper_funcs, like all the other
+        * helper-internal hooks.
         */
        int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe,
                                     unsigned int flags, int *vpos, int *hpos,
@@ -317,6 +322,11 @@ struct drm_driver {
         *
         * True on success, false on failure, which means the core should
         * fallback to a simple timestamp taken in drm_crtc_handle_vblank().
+        *
+        * FIXME:
+        *
+        * We should move this hook to &struct drm_crtc_funcs like all the other
+        * vblank hooks.
         */
        bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe,
                                     int *max_error,
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to