On Sat, Sep 16, 2017 at 8:20 AM, Christian König <ckoenig.leichtzumer...@gmail.com> wrote: > Am 15.09.2017 um 22:06 schrieb Arnd Bergmann: >> >> The structure returned from r600_audio_status() is only partially >> initialized, and older gcc versions (4.3 and 4.4) warn about this: >> >> drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status': >> drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used >> uninitialized in this function >> drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.connected' is used >> uninitialized in this function >> drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.offset' is used >> uninitialized in this function >> >> This is harmless and surprisingly correct in C99, as the caller >> only accesses the fields that got initialized, so newer compilers >> don't warn about it, but initializing the entire structure feels >> like the right thing to do here and avoids the warning. >> >> Signed-off-by: Arnd Bergmann <a...@arndb.de> > > > Reviewed-by: Christian König <christian.koe...@amd.com>
Applied. thanks! Alex > >> --- >> drivers/gpu/drm/radeon/r600_hdmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c >> b/drivers/gpu/drm/radeon/r600_hdmi.c >> index e82a99cb2459..ab32830c4e23 100644 >> --- a/drivers/gpu/drm/radeon/r600_hdmi.c >> +++ b/drivers/gpu/drm/radeon/r600_hdmi.c >> @@ -58,7 +58,7 @@ enum r600_hdmi_iec_status_bits { >> static struct r600_audio_pin r600_audio_status(struct radeon_device >> *rdev) >> { >> - struct r600_audio_pin status; >> + struct r600_audio_pin status = {}; >> uint32_t value; >> value = RREG32(R600_AUDIO_RATE_BPS_CHANNEL); > > > > _______________________________________________ > amd-gfx mailing list > amd-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel