2017-12-19 15:15 GMT+01:00 Philippe CORNU <philippe.co...@st.com>: > Hi Fabio, > > > On 12/18/2017 02:02 PM, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.este...@nxp.com> >> >> devm_ioremap_resource() already checks if the resource is NULL, so >> remove the unnecessary platform_get_resource() error check. >> >> Cc: Philippe Cornu <philippe.co...@st.com> >> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> >> --- >> drivers/gpu/drm/stm/ltdc.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c >> index 394613b..6dc5d4e 100644 >> --- a/drivers/gpu/drm/stm/ltdc.c >> +++ b/drivers/gpu/drm/stm/ltdc.c >> @@ -901,12 +901,6 @@ int ltdc_load(struct drm_device *ddev) >> } >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!res) { >> - DRM_ERROR("Unable to get resource\n"); >> - ret = -ENODEV; >> - goto err; >> - } >> - > > Many thanks for this cleanup. > > Acked-by: Philippe Cornu <philippe.co...@st.com>
Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > >> ldev->regs = devm_ioremap_resource(dev, res); >> if (IS_ERR(ldev->regs)) { >> DRM_ERROR("Unable to get ltdc registers\n"); >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel