On 07/02/18 14:10, Jyri Sarha wrote: > Call to omap_drm_irq_install() may fail with an error code. In such a > case the driver probe should fail. > > Signed-off-by: Jyri Sarha <jsa...@ti.com> > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c > b/drivers/gpu/drm/omapdrm/omap_drv.c > index 71ea43f..e6e7a2c 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -329,9 +329,9 @@ static int omap_modeset_init(struct drm_device *dev) > > drm_mode_config_reset(dev); > > - omap_drm_irq_install(dev); > + ret = omap_drm_irq_install(dev); > > - return 0; > + return ret; > }
It's better to do "if (ret) return ret;" so that it's easy (and less error prone) to modify the code later. Other than that: Reviewed-by: Tomi Valkeinen <tomi.valkei...@ti.com> Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
